phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3572) Support FETCH NEXT| n ROWS from Cursor
Date Wed, 17 May 2017 07:05:04 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16013647#comment-16013647
] 

Hadoop QA commented on PHOENIX-3572:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12868385/PHOENIX-3572.patch
  against master branch at commit 1666e932d157be732946e02b474b6c342199bc0f.
  ATTACHMENT ID: 12868385

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 13 new or modified
tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 47 warning messages.

    {color:red}-1 release audit{color}.  The applied patch generated 2 release audit warnings
(more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +            ResultSet rs = DriverManager.getConnection(getUrl()).prepareStatement(cursorSQL).executeQuery();
+                rs = DriverManager.getConnection(getUrl()).createStatement().executeQuery(cursorSQL);
+            ResultSet cursorRS = DriverManager.getConnection(getUrl()).prepareStatement(cursorSQL).executeQuery();
+            ResultSet rs = DriverManager.getConnection(getUrl()).prepareStatement(querySQL).executeQuery();
+                cursorRS = DriverManager.getConnection(getUrl()).prepareStatement(cursorSQL).executeQuery();
+            ResultSet rs = DriverManager.getConnection(getUrl()).prepareStatement(cursorSQL).executeQuery();
+                rs = DriverManager.getConnection(getUrl()).prepareStatement(cursorSQL).executeQuery();
+            ResultSet rs = DriverManager.getConnection(getUrl()).prepareStatement(cursorSQL).executeQuery();
+                rs = DriverManager.getConnection(getUrl()).prepareStatement(cursorSQL).executeQuery();
+            ResultSet rs = DriverManager.getConnection(getUrl()).prepareStatement(querySQL).executeQuery();

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/875//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/875//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/875//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/875//console

This message is automatically generated.

> Support FETCH NEXT| n ROWS from Cursor
> --------------------------------------
>
>                 Key: PHOENIX-3572
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3572
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Biju Nair
>            Assignee: Biju Nair
>             Fix For: 4.11.0
>
>         Attachments: PHOENIX-3572.patch
>
>
> Implement required changes to support 
> - {{DECLARE}} and {{OPEN}} a cursor
> - query {{FETCH NEXT | n ROWS}} from the cursor
> - {{CLOSE}} the cursor
> Based on the feedback in [PR #192|https://github.com/apache/phoenix/pull/192], implement
the changes using {{ResultSet}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message