phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamesRTaylor <...@git.apache.org>
Subject [GitHub] phoenix pull request #239: PHOENIX-3744: Support snapshot scanners for MR-ba...
Date Wed, 24 May 2017 17:22:57 GMT
Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/239#discussion_r118313746
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/PhoenixInputFormat.java
---
    @@ -185,7 +184,7 @@ private QueryPlan getQueryPlan(final JobContext context, final Configuration
con
                     scan.setAttribute(BaseScannerRegionObserver.TX_SCN, Bytes.toBytes(Long.valueOf(txnScnValue)));
                 }
                 // Initialize the query plan so it sets up the parallel scans
    -            queryPlan.iterator(MapReduceParallelScanGrouper.getInstance());
    +            queryPlan.iterator(TableMRParallelScanGrouper.init(configuration));
    --- End diff --
    
    Can't this just instantiate a TableMRParallelScanGrouper and the init method can be invoked
in the constructor so that it doesn't need to be exposed in the interface?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message