phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamesRTaylor <...@git.apache.org>
Subject [GitHub] phoenix pull request #239: PHOENIX-3744: Support snapshot scanners for MR-ba...
Date Wed, 24 May 2017 17:15:00 GMT
Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/239#discussion_r118311801
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/PhoenixMapReduceUtil.java
---
    @@ -63,6 +67,66 @@ public static void setInput(final Job job, final Class<? extends
DBWritable> inp
             PhoenixConfigurationUtil.setSchemaType(configuration, SchemaType.QUERY);
          }
     
    +    /**
    +     *
    +     * @param job
    +     * @param inputClass DBWritable class
    +     * @param snapshotName The name of a snapshot (of a table) to read from
    +     * @param tableName Input table name
    +     * @param restoreDir a temporary dir to copy the snapshot files into
    +     * @param conditions Condition clause to be added to the WHERE clause. Can be <tt>null</tt>
if there are no conditions.
    +     * @param fieldNames fields being projected for the SELECT query.
    +     */
    +    public static void setInput(final Job job, final Class<? extends DBWritable>
inputClass, final String snapshotName, String tableName,
    --- End diff --
    
    Why wouldn't we want to take the snapshot here instead of passing in the snapshot name?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message