phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rahulsIOT <...@git.apache.org>
Subject [GitHub] phoenix pull request #236: Loadbalancer
Date Fri, 19 May 2017 09:06:01 GMT
Github user rahulsIOT commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/236#discussion_r117436598
  
    --- Diff: phoenix-queryserver/pom.xml ---
    @@ -147,6 +147,14 @@
           <groupId>commons-logging</groupId>
           <artifactId>commons-logging</artifactId>
         </dependency>
    +    <dependency>
    +      <groupId>org.apache.phoenix</groupId>
    +      <artifactId>phoenix-queryserver-loadbalancer</artifactId>
    --- End diff --
    
    We just need to find a way to share LoadBalancer configurations such as base path, service
name, acls username and password ( and there defaults) between PQS and Load balancer. Both
these projects need these details to communicate to zookeeper. We cannot put the code in QueryService/QueryServiceOptions
as phoenix-core is not part of phoenix-Load-Balancer module. Let me think of better way to
abstract out the code so it would be used at both phoenix-queryserver and phoenix-load-balancer
modules. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message