phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] phoenix pull request #242: PQS metrics - https://issues.apache.org/jira/brow...
Date Wed, 17 May 2017 15:52:38 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/242#discussion_r117041326
  
    --- Diff: phoenix-queryserver/src/main/java/org/apache/phoenix/queryserver/metrics/sink/PqsFileSink.java
---
    @@ -0,0 +1,66 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.phoenix.queryserver.metrics.sink;
    +
    +
    +import org.apache.phoenix.queryserver.metrics.PqsConfiguration;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.io.File;
    +import java.io.FileNotFoundException;
    +import java.io.UnsupportedEncodingException;
    +import java.io.FileOutputStream;
    +import java.io.PrintStream;
    +
    +
    +public class PqsFileSink extends PqsSink {
    +
    +    private PrintStream writer;
    +    private static final Logger LOG = LoggerFactory.getLogger(PqsFileSink.class);
    +    private String filename = PqsConfiguration.getFileSinkFilename();
    +
    +    public PqsFileSink() {
    +        try {
    +            writer = filename == null ? System.out
    +                    : new PrintStream(new FileOutputStream(new File(filename)),
    +                    true, "UTF-8");
    +        } catch (FileNotFoundException e) {
    +            LOG.error("Error creating "+ filename, e);
    --- End diff --
    
    Ah, I didn't look down below.
    
    Follow-on, why do you want this to fail? This could lead to an operator who thinks they're
collecting metrics to not actually get them. It seems reasonable to me that, if the user configures
metrics with an invalid/unwritable path, they should see an error propagated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message