phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamesRTaylor <...@git.apache.org>
Subject [GitHub] phoenix pull request #248: Phoenix 3534
Date Mon, 15 May 2017 23:41:30 GMT
Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/248#discussion_r116626201
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
    @@ -381,7 +383,8 @@
                 IS_VIEW_REFERENCED_KV,
                 COLUMN_DEF_KV,
                 IS_ROW_TIMESTAMP_KV,
    -            COLUMN_QUALIFIER_KV
    +            COLUMN_QUALIFIER_KV,
    +            DROPPED_COLUMN_KV
    --- End diff --
    
    I don't think you need this DROPPED_COLUMN_KV since you're not reading this when the column
is read (but instead when the linking rows are read). If that's right, let's remove it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message