phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamesRTaylor <...@git.apache.org>
Subject [GitHub] phoenix pull request #239: Phoenix-3744: Support snapshot scanners for MR-ba...
Date Mon, 15 May 2017 18:06:25 GMT
Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/239#discussion_r116560730
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
---
    @@ -496,6 +496,17 @@ public BaseResultIterators(QueryPlan plan, Integer perScanLimit,
Integer offset,
                 return scans;
         }
     
    +    private List<HRegionLocation> getRegionBoundaries(ParallelScanGrouper scanGrouper)
    +        throws SQLException{
    +        if (scanGrouper instanceof DefaultParallelScanGrouper) {
    --- End diff --
    
    These casts should not be necessary. Either add an init method to ParallelScanGrouper
or call the init from the implementing class in getRegionBoundaries.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message