phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] phoenix pull request #242: PQS metrics - https://issues.apache.org/jira/brow...
Date Mon, 01 May 2017 14:46:57 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/242#discussion_r114132800
  
    --- Diff: phoenix-queryserver/src/it/java/org/apache/phoenix/end2end/QueryServerBasicsIT.java
---
    @@ -161,5 +184,19 @@ public void smokeTest() throws Exception {
             }
           }
         }
    +    assertFalse(" metrics file should not be empty", checkIfTempFileIsEmpty());
    --- End diff --
    
    Can you add a test which actually verifies that some of the metrics we'd expect to be
in this file are there?
    
    This test would silently pass if garbage/errors were somehow written to this file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message