phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] phoenix pull request #242: PQS metrics - https://issues.apache.org/jira/brow...
Date Mon, 01 May 2017 14:46:57 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/242#discussion_r114132550
  
    --- Diff: phoenix-queryserver/src/main/java/org/apache/phoenix/queryserver/server/PhoenixMetaFactoryImpl.java
---
    @@ -68,7 +70,10 @@ public Meta create(List<String> args) {
                 "0 or 1 argument expected. Received " + Arrays.toString(args.toArray()));
           }
           // TODO: what about -D configs passed in from cli? How do they get pushed down?
    -      return new JdbcMeta(url, info);
    +      if (PqsConfiguration.isMetricsTurnedOn()) {
    --- End diff --
    
    Only return a `PQSMetricsMeta` if metrics collection is enabled.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message