Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@phoenix.apache.org
Date: Thu, 6 Apr 2017 18:04:41 +0000 (UTC)
From: "James Taylor (JIRA)" <jira@apache.org>
To: dev@phoenix.apache.org
Message-ID: <JIRA.13061929.1491438478000.227223.1491501881601@Atlassian.JIRA>
In-Reply-To: <JIRA.13061929.1491438478000@Atlassian.JIRA>
References: <JIRA.13061929.1491438478000@Atlassian.JIRA> <JIRA.13061929.1491438478723@jira-lw-us.apache.org>
Subject: [jira] [Commented] (PHOENIX-3767) Prevent spurious tracing spans
 from Hadoop being written in Phoenix Trace tables
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 06 Apr 2017 18:04:52 -0000


    [ https://issues.apache.org/jira/browse/PHOENIX-3767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959458#comment-15959458 ] 

James Taylor commented on PHOENIX-3767:
---------------------------------------

Thanks for the patch, [~karanmehta93]. Your workaround to filter out metrics with a trace ID of 0 is a good one. I believe the relevant code change for that is here in the private Metric class within TraceMetricSource?
{code}
+        if (span.getTraceId() != 0 && spanQueue.offer(span) )
+            LOG.info("Span buffered to queue " + span.toJson());
+        else
+            LOG.info("Span NOT buffered due to overflow in queue " + span.toJson());
{code}
Would you mind attaching only the diff on top of your other patch for PHOENIX-3752 (and note that this depends on that one)? Also, please resolve PHOENIX-3062 as "Will Not Fix" as it seems it's eclipsed by your other patch.

[~samarthjain] - would you mind reviewing/committing this one and PHOENIX-3752?

> Prevent spurious tracing spans from Hadoop being written in Phoenix Trace tables
> --------------------------------------------------------------------------------
>
>                 Key: PHOENIX-3767
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3767
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Karan Mehta
>            Assignee: Karan Mehta
>         Attachments: PHOENIX-3767.001.patch
>
>
> PHOENIX-3752 is the JIRA to remove Hadoop Metrics-2 system from the Phoenix Framework, whose task is to deliver the received HTrace spans to the phoenix table. When replacing this system with a simple one as discussed on this JIRA, one of the current test {{testClientServerIndexingTracing()}} triggers a bug in Hadoop (HDFS-11583), which causes spurious {{writeTo}} spans being generated from {{DataStreamer}} class. 
> Since Phoenix implements its {{SpanReceiver}} to receive the HTrace spans, all these spans are redirected over here, which eventually get persisted into Phoenix tables with the system developed in PHOENIX-3752. The information is useless and might use up unnecessary space. 
> This JIRA is to add a patch to ignore those spans and prevent them from being written to Phoenix tables. 


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)