phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ankit Singhal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3809) CURRENT_DATE() (with parentheses) is illegal in Calcite
Date Fri, 28 Apr 2017 06:26:04 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15988283#comment-15988283
] 

Ankit Singhal commented on PHOENIX-3809:
----------------------------------------

bq. I think having a version that allows parentheses would ease the transition from 4.x to
5.0, so supporting it would be useful.
Raised pull request for the same. 
https://github.com/apache/calcite/pull/438

though it's not a standard SQL but CURRENT_DATE (with and without parentheses) is also allowed
in Mysql, so IMO continuing supporting at our side would not be that bad.


> CURRENT_DATE() (with parentheses) is illegal in Calcite
> -------------------------------------------------------
>
>                 Key: PHOENIX-3809
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3809
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Ankit Singhal
>            Assignee: Ankit Singhal
>              Labels: calcite
>
> Calcite doesn't allow system functions to be specified with parenthesis who doesn't accept
arguments.
> For eg:-
> CURRENT_DATE() is illegal whereas CURRENT_DATE is expected.
> At validation level:- SqlValidatorImpl#validateCall 
> {code}
>     if ((call.operandCount() == 0)
>         && (operator.getSyntax() == SqlSyntax.FUNCTION_ID)
>         && !call.isExpanded()) {
>       // For example, "LOCALTIME()" is illegal. (It should be
>       // "LOCALTIME", which would have been handled as a
>       // SqlIdentifier.)
>       throw handleUnresolvedFunction(call, (SqlFunction) operator,
>           ImmutableList.<RelDataType>of(), null);
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message