phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3801) Demote extremely verbose logs in ParallelWriterIndexCommitter from DEBUG to TRACE
Date Fri, 21 Apr 2017 00:23:04 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977853#comment-15977853
] 

Hadoop QA commented on PHOENIX-3801:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12864386/PHOENIX-3801.patch
  against master branch at commit 5bd7f79b51309505a19f854d05cb000f5cd1eb9f.
  ATTACHMENT ID: 12864386

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 47 warning messages.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +                        LOG.trace("Writing index update:" + mutations + " to table: "
+ tableReference);
+                                    LOG.trace("indexRegion.batchMutate failed and fall back
to HTable.batch(). Got error="
+                            LOG.trace("Writing index update:" + mutations + " to table: "
+ tableReference);

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexFailureIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/837//testReport/
Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/837//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/837//console

This message is automatically generated.

> Demote extremely verbose logs in ParallelWriterIndexCommitter from DEBUG to TRACE
> ---------------------------------------------------------------------------------
>
>                 Key: PHOENIX-3801
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3801
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>            Priority: Trivial
>         Attachments: PHOENIX-3801.patch
>
>
> ParallelWriterIndexCommitter and TrackingParallelWriterIndexCommitter will stringify
and dump to log all mutations in an index update at DEBUG level. This is unexpected. That
level of detail is suitable only for specific debugging scenarios, so move it to TRACE level.




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message