phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ankit Singhal (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (PHOENIX-3792) Provide way to skip normalization of column names in phoenix-spark integration
Date Thu, 20 Apr 2017 13:49:04 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976709#comment-15976709
] 

Ankit Singhal edited comment on PHOENIX-3792 at 4/20/17 1:48 PM:
-----------------------------------------------------------------

Thanks [~jmahonin] for the review. Please find the updated patch.
bq. We should replace 2.11 above with ${scala.binary.version}
I think it's ok to test "skipNormalizingIdentifier" option without Avro for now.

bq. Also, I +1'd PHOENIX-3751 earlier, though perhaps you're waiting for user feedback.
it got skipped from my radar, will commit along with this. 


was (Author: ankit@apache.org):
Thanks [~jmahonin] for the review. Please find the updated patch.
bq. We should replace 2.11 above with ${scala.binary.version}
I think it's to test "skipNormalizingIdentifier" option without Avro for now.

bq. Also, I +1'd PHOENIX-3751 earlier, though perhaps you're waiting for user feedback.
it got skipped from my radar, will commit along with this.

> Provide way to skip normalization of column names in phoenix-spark integration
> ------------------------------------------------------------------------------
>
>                 Key: PHOENIX-3792
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3792
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Ankit Singhal
>            Assignee: Ankit Singhal
>             Fix For: 4.11.0
>
>         Attachments: PHOENIX-3792.patch, PHOENIX-3792_v1.patch
>
>
> If the user is reading an AVRO file and writing to a Phoenix table with case sensitive
column names, then we should provide the user with an option to skip the normalisation as
it seems there is no way to escape double quotes for the column names in Avro schema.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message