phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3757) System mutex table not being created in SYSTEM namespace when namespace mapping is enabled
Date Tue, 04 Apr 2017 18:42:41 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955598#comment-15955598
] 

Hadoop QA commented on PHOENIX-3757:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12861920/PHOENIX-3757.001.patch
  against master branch at commit 2c53fc9856ba3770e742c0729cdef9b2c0181873.
  ATTACHMENT ID: 12861920

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 47 warning messages.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +                                        // User might not be privileged to access the
Phoenix system tables
+                                        // in the HBase "SYSTEM" namespace (lacking 'ADMIN').
Let them proceed without
+                                        logger.warn("Could not access system namespace, assuming
it exists");
+                                    // Create the mutex table if it doesn't already exist,
do this before ensureSystemTablesUpgraded
+                                    // so that it will be moved into the SYSTEM namespace
if necessary
+                                    createSysMutexTable(admin, ConnectionQueryServicesImpl.this.getProps());
+                                    if (!ensureSystemTablesUpgraded(ConnectionQueryServicesImpl.this.getProps()))
{
+                                        logger.debug("Failed to upgrade system tables, assuming
they are properly configured.");
+                                    // Make sure to also create the mutex table when namespace
mapping is disabled
+                                    createSysMutexTable(admin, ConnectionQueryServicesImpl.this.getProps());

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/820//testReport/
Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/820//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/820//console

This message is automatically generated.

> System mutex table not being created in SYSTEM namespace when namespace mapping is enabled
> ------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-3757
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3757
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Critical
>             Fix For: 4.11.0
>
>         Attachments: PHOENIX-3757.001.patch
>
>
> Noticed this issue while writing a test for PHOENIX-3756:
> The SYSTEM.MUTEX table is always created in the default namespace, even when {{phoenix.schema.isNamespaceMappingEnabled=true}}.
At a glance, it looks like the logic for the other system tables isn't applied to the mutex
table.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message