phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3715) Calcite-Phoenix exceptions do not match error code or specific SQLException sub-classes
Date Fri, 21 Apr 2017 19:09:06 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15979232#comment-15979232
] 

James Taylor commented on PHOENIX-3715:
---------------------------------------

We're ignoring all error code differences as well as ignoring explain plan differences. Why
don't we just ignore all failing tests (smile)?

I'm -1 on this approach. I think we need to fix the tests, not just ignore these differences.
Clients rely on these error codes, so we can't release a version that changes all the error
codes.

Can we pursue bubbling up the Phoenix exception codes?

> Calcite-Phoenix exceptions do not match error code or specific SQLException sub-classes
> ---------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-3715
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3715
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Maryann Xue
>            Assignee: Rajeshbabu Chintaguntla
>            Priority: Minor
>              Labels: calcite
>         Attachments: PHOENIX-3715.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message