phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3572) Support FETCH NEXT| n ROWS from Cursor
Date Wed, 05 Apr 2017 18:57:41 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957446#comment-15957446
] 

ASF GitHub Bot commented on PHOENIX-3572:
-----------------------------------------

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/229#discussion_r109999908
  
    --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/CursorWithRowValueConstructorIT.java
---
    @@ -0,0 +1,687 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.phoenix.end2end;
    +
    +import org.apache.commons.logging.Log;
    +import org.apache.commons.logging.LogFactory;
    +import org.apache.phoenix.util.*;
    +import org.junit.After;
    +import org.junit.Before;
    +import org.junit.BeforeClass;
    +import org.junit.Test;
    +
    +import java.math.BigDecimal;
    +import java.sql.*;
    +import java.util.Properties;
    +import java.util.Random;
    +
    +import static org.apache.phoenix.util.TestUtil.*;
    +import static org.junit.Assert.*;
    +
    +
    +public class CursorWithRowValueConstructorIT extends BaseClientManagedTimeIT {
    --- End diff --
    
    We're trying to get rid of all tests derived from BaseClientManagedTimeIT. Please derive
from ParallelStatsDisabledIT instead, letting HBase manage the timestamps, and generate unique
table names for each test (see other tests for examples).


> Support FETCH NEXT| n ROWS from Cursor
> --------------------------------------
>
>                 Key: PHOENIX-3572
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3572
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Biju Nair
>            Assignee: Biju Nair
>
> Implement required changes to support 
> - {{DECLARE}} and {{OPEN}} a cursor
> - query {{FETCH NEXT | n ROWS}} from the cursor
> - {{CLOSE}} the cursor
> Based on the feedback in [PR #192|https://github.com/apache/phoenix/pull/192], implement
the changes using {{ResultSet}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message