Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B9825200C28 for ; Mon, 13 Mar 2017 07:59:09 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id B832B160B60; Mon, 13 Mar 2017 06:59:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0BDE9160B85 for ; Mon, 13 Mar 2017 07:59:08 +0100 (CET) Received: (qmail 25909 invoked by uid 500); 13 Mar 2017 06:59:08 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 25644 invoked by uid 99); 13 Mar 2017 06:59:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Mar 2017 06:59:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 8DD47C6C80 for ; Mon, 13 Mar 2017 06:59:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.451 X-Spam-Level: * X-Spam-Status: No, score=1.451 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 4SotV2n4KTxr for ; Mon, 13 Mar 2017 06:59:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 001B65F252 for ; Mon, 13 Mar 2017 06:59:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0451FE0146 for ; Mon, 13 Mar 2017 06:59:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 8AD8024162 for ; Mon, 13 Mar 2017 06:59:04 +0000 (UTC) Date: Mon, 13 Mar 2017 06:59:04 +0000 (UTC) From: "Kevin Liew (JIRA)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (PHOENIX-3732) Support for dynamic columns in UPSERT in Phoenix-Calcite MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 13 Mar 2017 06:59:09 -0000 [ https://issues.apache.org/jira/browse/PHOENIX-3732?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D15= 906933#comment-15906933 ]=20 Kevin Liew edited comment on PHOENIX-3732 at 3/13/17 6:58 AM: -------------------------------------------------------------- The Phoenix grammar for dynamic columns in {{UPSERT}} differs from the gram= mar defined in CALCITE-493 at https://issues.apache.org/jira/browse/CALCITE= -493?focusedCommentId=3D14270040&page=3Dcom.atlassian.jira.plugin.system.is= suetabpanels:comment-tabpanel#comment-14270040 Phoenix allows embedding dynamic column definitions in the target column li= st whereas Calcite (support for extended columns in {{INSERT/UPSERT}} isn't= implemented yet, but I am working on a patch for that) requires that exten= ded columns be specified separately from the target columns. ie. Phoenix {code:sql} UPSERT INTO EventLog (eventId, eventTime, eventType, lastGCTime TIME, usedMemory BIGINT, maxMemo= ry BIGINT) VALUES (1, CURRENT_TIME(), =E2=80=98abc=E2=80=99, CURRENT_TIME(), 512, 1024= ); {code} Calcite {code:sql} UPSERT INTO EventLog (lastGCTime TIME, usedMemory BIGINT, maxMemory BIGINT) (eventId, eventTime, eventType, lastGCTime, usedMemory, maxMemory) VALUES (1, CURRENT_TIME(), =E2=80=98abc=E2=80=99, CURRENT_TIME(), 512, 1024= ); {code} [~julianhyde], do we want to allow embedding extended column definitions in= the target column list in Calcite? Or is this something that should be spe= cific to Phoenix? was (Author: kliew): The Phoenix grammar for dynamic columns in {{UPSERT}} differs from the gram= mar defined in CALCITE-493 at https://issues.apache.org/jira/browse/CALCITE= -493?focusedCommentId=3D14270040&page=3Dcom.atlassian.jira.plugin.system.is= suetabpanels:comment-tabpanel#comment-14270040 Phoenix allows embedding dynamic column definitions in the target column li= st whereas Calcite (support for extended columns in {{INSERT/UPSERT}} isn't= implemented yet, but I am working on a patch for that) requires that exten= ded columns be specified separately from the target columns. [~julianhyde], do we want to allow embedding extended column definitions in= the target column list in Calcite? Or is this something that should be spe= cific to Phoenix? > Support for dynamic columns in UPSERT in Phoenix-Calcite > -------------------------------------------------------- > > Key: PHOENIX-3732 > URL: https://issues.apache.org/jira/browse/PHOENIX-3732 > Project: Phoenix > Issue Type: Bug > Reporter: Kevin Liew > Labels: calcite > > https://phoenix.apache.org/dynamic_columns.html > {quote} > To upsert a row with dynamic columns: > UPSERT INTO EventLog (eventId, eventTime, eventType, lastGCTime TIME, use= dMemory BIGINT, maxMemory BIGINT) VALUES(1, CURRENT_TIME(), =E2=80=98abc=E2= =80=99, CURRENT_TIME(), 512, 1024); > {quote} -- This message was sent by Atlassian JIRA (v6.3.15#6346)