phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Csaba Skrabak (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3071) Surface more information on failed locations
Date Fri, 10 Mar 2017 10:37:04 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15904870#comment-15904870
] 

Csaba Skrabak commented on PHOENIX-3071:
----------------------------------------

What method exactly is throwing RetriesExhaustedWithDetailsException in which case? I'm looking
for easy things to fix but this one is not clear enough to me.

> Surface more information on failed locations
> --------------------------------------------
>
>                 Key: PHOENIX-3071
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3071
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Andrew Purtell
>            Priority: Minor
>
> Phoenix is throwing a RetriesExhaustedWithDetailsException out of MutationState. RetriesExhaustedWithDetailsException
carries a lot of interesting information accessible via type specific methods. Instead of
just rethrowing RetriesExhaustedWithDetailsException, MutationState should construct a CommitException
that enumerates rows and last known server location using RetriesExhaustedWithDetailsException#getRow(int)
and RetriesExhaustedWithDetailsException#getHostnamePort(int). 
> Consider alerts of the form (prettily formatted):
> {noformat}
> CommitException: RetriesExhaustedWithDetailsException: 
> Failed 88 actions: IOException: 88 times, at MutationState [
>   Table: TEST_TABLE [
>     Row: testRowc1900d75072f9fc8217735631dda44a3
>         Location: host1234.domain.company.com,
>     Row:  ... 
>    ]
> ]
> {noformat}
> The additional information in the exception message can significantly aid debugging and
remediation efforts because the location(s) causing issues for the client will be known up
front.
> Probably want to stop enumerating after a configurable number of locations and skip an
entry if the preceding entry also has the same row and location.
> Should do the same wherever rethrowing or bubbling up RetriesExhaustedWithDetailsException.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message