Return-Path: <dev-return-39002-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 74B23200C36
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Fri, 24 Feb 2017 01:12:13 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 736E0160B7F; Fri, 24 Feb 2017 00:12:13 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id B5551160B67
	for <archive-asf-public@cust-asf.ponee.io>; Fri, 24 Feb 2017 01:12:12 +0100 (CET)
Received: (qmail 30053 invoked by uid 500); 24 Feb 2017 00:12:11 -0000
Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@phoenix.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@phoenix.apache.org>
List-Post: <mailto:dev@phoenix.apache.org>
List-Id: <dev.phoenix.apache.org>
Reply-To: dev@phoenix.apache.org
Delivered-To: mailing list dev@phoenix.apache.org
Received: (qmail 29407 invoked by uid 99); 24 Feb 2017 00:12:11 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Feb 2017 00:12:11 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 06EB8DF9F8; Fri, 24 Feb 2017 00:12:11 +0000 (UTC)
From: JamesRTaylor <git@git.apache.org>
To: dev@phoenix.apache.org
Reply-To: dev@phoenix.apache.org
References: <git-pr-232-phoenix@git.apache.org>
In-Reply-To: <git-pr-232-phoenix@git.apache.org>
Subject: [GitHub] phoenix pull request #232: Pull request for merging the encode columns branc...
Content-Type: text/plain
Message-Id: <20170224001211.06EB8DF9F8@git1-us-west.apache.org>
Date: Fri, 24 Feb 2017 00:12:11 +0000 (UTC)
archived-at: Fri, 24 Feb 2017 00:12:13 -0000

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/232#discussion_r102851976
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/PTableImpl.java ---
    @@ -106,7 +115,8 @@
         private List<PColumnFamily> families;
         private Map<byte[], PColumnFamily> familyByBytes;
         private Map<String, PColumnFamily> familyByString;
    -    private ListMultimap<String,PColumn> columnsByName;
    +    private ListMultimap<String, PColumn> columnsByName;
    +    private Map<KVColumnFamilyQualifier, PColumn> kvColumnsByQualifiers;
    --- End diff --
    
    It's unfortunate that we need another map. Is this used often?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---