phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rahul Shrivastava (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3655) Metrics for PQS
Date Fri, 10 Feb 2017 19:41:41 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861738#comment-15861738
] 

Rahul Shrivastava commented on PHOENIX-3655:
--------------------------------------------

[~elserj] - My answers inline. 

>--------  I think it's important to make the distinction between "application level" metrics
that Phoenix can/does collect and PQS-specific metrics. There are some basic things instrumented
in PQS but these are RPC-level (as opposed to the aforementioned application-level) metrics.
Keeping a clear distinction between kinds of metrics would be good.

Could you please elaborate ? My understanding is PQS comes with Phoenix driver. The client
of the phoenix driver needs to make specific calls to PhoenixRuntime to generate the metrics
and push it to the sink. 


Have you investigated using HTrace? - I will try Htrace but IMHO, Htrace would be not a good
substitute for metrics collection. In past, we had system with tracing and metrics collection.
After all, we can turn on tracing for a small fraction of request.  

> Metrics for PQS
> ---------------
>
>                 Key: PHOENIX-3655
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3655
>             Project: Phoenix
>          Issue Type: New Feature
>    Affects Versions: 4.8.0
>         Environment: Linux 3.13.0-107-generic kernel, v4.9.0-HBase-0.98
>            Reporter: Rahul Shrivastava
>             Fix For: 4.9.0
>
>   Original Estimate: 240h
>  Remaining Estimate: 240h
>
> Phoenix Query Server runs a separate process compared to its thin client. Metrics collection
is currently done by PhoenixRuntime.java i.e. at Phoenix driver level. We need the following
> 1. For every jdbc statement/prepared statement/ run by PQS , we need capability to collect
metrics at PQS level and push the data to external sink i.e. file, JMX , other external custom
sources. 
> 2. Besides this global metrics could be periodically collected and pushed to the sink.

> 2. PQS can be configured to turn on metrics collection and type of collect ( runtime
or global) via hbase-site.xml
> 3. Sink could be configured via an interface in hbase-site.xml. 
> All metrics definition https://phoenix.apache.org/metrics.html



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message