phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamesRTaylor <...@git.apache.org>
Subject [GitHub] phoenix pull request #232: Pull request for merging the encode columns branc...
Date Fri, 24 Feb 2017 00:12:11 GMT
Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/232#discussion_r102848050
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/FromCompiler.java ---
    @@ -858,7 +868,7 @@ public ColumnRef resolveColumn(String schemaName, String tableName,
String colNa
                     while (iterator.hasNext()) {
                         TableRef tableRef = iterator.next();
                         try {
    -                        PColumn column = tableRef.getTable().getColumn(colName);
    +                        PColumn column = tableRef.getTable().getPColumnForColumnName(colName);
    --- End diff --
    
    Any reason for the method rename? There might be usages of this API outside of the Phoenix
jar (for example by the Platform teams), so I'd resist making this change unless it's absolutely
necessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message