Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3C16F200C15 for ; Wed, 25 Jan 2017 00:36:46 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 3AFFB160B4B; Tue, 24 Jan 2017 23:36:46 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 85048160B3E for ; Wed, 25 Jan 2017 00:36:45 +0100 (CET) Received: (qmail 30328 invoked by uid 500); 24 Jan 2017 23:36:44 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 30317 invoked by uid 99); 24 Jan 2017 23:36:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Jan 2017 23:36:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 4F521C07F4 for ; Tue, 24 Jan 2017 23:36:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.199 X-Spam-Level: X-Spam-Status: No, score=-1.199 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id AMJng0sP5D1e for ; Tue, 24 Jan 2017 23:36:43 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 17BD45F4EC for ; Tue, 24 Jan 2017 23:36:43 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id CC6A7E012C for ; Tue, 24 Jan 2017 23:36:26 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 679BB25286 for ; Tue, 24 Jan 2017 23:36:26 +0000 (UTC) Date: Tue, 24 Jan 2017 23:36:26 +0000 (UTC) From: "Andrew Purtell (JIRA)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-3607) Change hashCode calculation for caching ConnectionQueryServicesImpls MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 24 Jan 2017 23:36:46 -0000 [ https://issues.apache.org/jira/browse/PHOENIX-3607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15836852#comment-15836852 ] Andrew Purtell commented on PHOENIX-3607: ----------------------------------------- bq. User's strange Subject instance-based hashing is done for a valid reason given the quirks of Hadoop authentication. After further consideration I agree. Let's close this as Wont Fix. > Change hashCode calculation for caching ConnectionQueryServicesImpls > -------------------------------------------------------------------- > > Key: PHOENIX-3607 > URL: https://issues.apache.org/jira/browse/PHOENIX-3607 > Project: Phoenix > Issue Type: Bug > Affects Versions: 4.8.0, 4.9.0 > Reporter: Geoffrey Jacoby > Assignee: Geoffrey Jacoby > > PhoenixDriver maintains a cache of ConnectionInfo -> ConnectionQueryServicesImpl (each of which holds a single HConnection) : > The hash code of ConnectionInfo in part uses the hash code of its HBase User object, which uses the *identity hash* of the Subject allocated at login. There are concerns about the stability of this hashcode. When we log out and log in after TGT refresh, will we have a new Subject? > To be defensive, we should do a hash of the string returned by user.getName() instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332)