phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3611) ConnectionQueryService cache should expire LRU entries
Date Wed, 25 Jan 2017 21:04:26 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838575#comment-15838575
] 

Hadoop QA commented on PHOENIX-3611:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12849358/PHOENIX-3611-v3.patch
  against master branch at commit b9323e1d30ba6b449f059b86ae7b8157de16b13d.
  ATTACHMENT ID: 12849358

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/744//console

This message is automatically generated.

> ConnectionQueryService cache should expire LRU entries
> ------------------------------------------------------
>
>                 Key: PHOENIX-3611
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3611
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.8.0, 4.9.0
>            Reporter: Geoffrey Jacoby
>            Assignee: Geoffrey Jacoby
>             Fix For: 4.10.0
>
>         Attachments: PHOENIX-3611.patch, PHOENIX-3611-v2.patch, PHOENIX-3611-v3.patch
>
>
> Currently the cache of ConnectionInfo/ConnectionQueryServicesImpl can hold its entries
forever. This can potentially lead to orphan cache entries, and since each ConnectionQueryServicesImpl
object has an HConnection, it can also lead to leaked connections. 
> Due to the way that ConnectionInfo hashing works (see PHOENIX-3126 and PHOENIX-3607),
this is particularly likely on a secure cluster. 
> The cache should be changed into an LRU-style cache with a fixed size and gradual expiration.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message