phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Geoffrey Jacoby (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3607) Change hashCode calculation for caching ConnectionQueryServicesImpls
Date Wed, 25 Jan 2017 20:51:26 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838554#comment-15838554
] 

Geoffrey Jacoby commented on PHOENIX-3607:
------------------------------------------

I reopened PHOENIX-3611 and submitted a v3 patch along the lines that [~apurtell] suggests
above, that removes the max size restriction. 

> Change hashCode calculation for caching ConnectionQueryServicesImpls
> --------------------------------------------------------------------
>
>                 Key: PHOENIX-3607
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3607
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.8.0, 4.9.0
>            Reporter: Geoffrey Jacoby
>            Assignee: Geoffrey Jacoby
>
> PhoenixDriver maintains a cache of ConnectionInfo -> ConnectionQueryServicesImpl (each
of which holds a single HConnection) : 
> The hash code of ConnectionInfo in part uses the hash code of its HBase User object,
which uses the *identity hash* of the Subject allocated at login. There are concerns about
the stability of this hashcode. When we log out and log in after TGT refresh, will we have
a new Subject?
> To be defensive, we should do a hash of the string returned by user.getName() instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message