phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3607) Change hashCode calculation for caching ConnectionQueryServicesImpls
Date Wed, 25 Jan 2017 01:19:26 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15836987#comment-15836987
] 

James Taylor commented on PHOENIX-3607:
---------------------------------------

How the age is determined? If it's based on when the ConnectionQueryService was initially
added to the cache and there are many that are being added to the cache, then we'll end up
closing a legitimate connection rather than one of the probably unused one. This may need
a little more thought. We'd be better of if we aged-out ConnectionQueryServices on which a
PhoenixConnection was never established.

> Change hashCode calculation for caching ConnectionQueryServicesImpls
> --------------------------------------------------------------------
>
>                 Key: PHOENIX-3607
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3607
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.8.0, 4.9.0
>            Reporter: Geoffrey Jacoby
>            Assignee: Geoffrey Jacoby
>
> PhoenixDriver maintains a cache of ConnectionInfo -> ConnectionQueryServicesImpl (each
of which holds a single HConnection) : 
> The hash code of ConnectionInfo in part uses the hash code of its HBase User object,
which uses the *identity hash* of the Subject allocated at login. There are concerns about
the stability of this hashcode. When we log out and log in after TGT refresh, will we have
a new Subject?
> To be defensive, we should do a hash of the string returned by user.getName() instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message