phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3563) Ensure we release ZooKeeper resources allocated by the Tephra client embedded in the Phoenix connection
Date Thu, 05 Jan 2017 02:09:58 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15800014#comment-15800014
] 

Hadoop QA commented on PHOENIX-3563:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12845676/PHOENIX-3563.patch
  against master branch at commit a0e5efcec5a1a732b2dce9794251242c3d66eea6.
  ATTACHMENT ID: 12845676

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 43 warning messages.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +            this.connection = HBaseFactoryProvider.getHConnectionFactory().createConnection(this.config);
+            // only initialize the tx service client if needed and if we succeeded in getting
a connection

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexFailureIT

     {color:red}-1 core zombie tests{color}.  There are 4 zombie test(s): 	at org.apache.hadoop.hdfs.TestRollingUpgrade.testRollback(TestRollingUpgrade.java:329)
	at org.apache.hadoop.hdfs.TestPread.testMaxOutHedgedReadPool(TestPread.java:434)
	at org.apache.hadoop.hdfs.TestDFSStartupVersions.testVersions(TestDFSStartupVersions.java:264)
	at org.apache.hadoop.test.GenericTestUtils.waitFor(GenericTestUtils.java:266)
	at org.apache.hadoop.hdfs.qjournal.TestSecureNNWithQJM.testSecureMode(TestSecureNNWithQJM.java:173)

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/716//testReport/
Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/716//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/716//console

This message is automatically generated.

> Ensure we release ZooKeeper resources allocated by the Tephra client embedded in the
Phoenix connection
> -------------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-3563
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3563
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.9.0
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>             Fix For: 4.9.1, 4.10.0, 5.0
>
>         Attachments: PHOENIX-3563.patch, PHOENIX-3563.patch
>
>
> When transactions are enabled the Phoenix client will create some Tephra client objects,
including TephraZKClientService, which embeds a ZooKeeper instance. Ensure that ZooKeeper
instance is properly shut down via ZooKeeper#close. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message