Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 04457200BEB for ; Wed, 14 Dec 2016 01:23:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 02EBA160B36; Wed, 14 Dec 2016 00:23:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 795A3160B23 for ; Wed, 14 Dec 2016 01:22:59 +0100 (CET) Received: (qmail 17596 invoked by uid 500); 14 Dec 2016 00:22:58 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 17564 invoked by uid 99); 14 Dec 2016 00:22:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Dec 2016 00:22:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 63E2D2C0087 for ; Wed, 14 Dec 2016 00:22:58 +0000 (UTC) Date: Wed, 14 Dec 2016 00:22:58 +0000 (UTC) From: "Nick Dimiduk (JIRA)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-3517) Use argparse in sqlline-thin.py MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 14 Dec 2016 00:23:00 -0000 [ https://issues.apache.org/jira/browse/PHOENIX-3517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15746719#comment-15746719 ] Nick Dimiduk commented on PHOENIX-3517: --------------------------------------- bq. Would somethign like virtualenv be a tool to use here? Or should we just avoid opening the can of worms on non-default-modules entirely? Virtualenv would be super complicated for us; it's not worth it just for arg-parsing. If you're happy with the library you're using, then just use it. If we really wanted docopt, i think it has no dependencies, which means we could drop the file into our bin dir and just use it (license permitting distribution, of course). > Use argparse in sqlline-thin.py > ------------------------------- > > Key: PHOENIX-3517 > URL: https://issues.apache.org/jira/browse/PHOENIX-3517 > Project: Phoenix > Issue Type: Improvement > Reporter: Josh Elser > Assignee: Josh Elser > Fix For: 4.10.0 > > Attachments: PHOENIX-3517.patch > > > sqlline-thin.py just does hand-rolled argument parsing. We can simplify the code, make better usage and validation choices, and support some extra options that we presently default to. > Python's argparse does all of these for us. -- This message was sent by Atlassian JIRA (v6.3.4#6332)