Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@phoenix.apache.org
Date: Sun, 4 Dec 2016 00:09:58 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: dev@phoenix.apache.org
Message-ID: <JIRA.13025363.1480804349000.432670.1480810198328@Atlassian.JIRA>
In-Reply-To: <JIRA.13025363.1480804349000@Atlassian.JIRA>
References: <JIRA.13025363.1480804349000@Atlassian.JIRA> <JIRA.13025363.1480804349603@arcas>
Subject: [jira] [Commented] (PHOENIX-3517) Use argparse in sqlline-thin.py
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sun, 04 Dec 2016 00:10:00 -0000


    [ https://issues.apache.org/jira/browse/PHOENIX-3517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15718979#comment-15718979 ] 

Hadoop QA commented on PHOENIX-3517:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12841649/PHOENIX-3517.patch
  against master branch at commit 683e1f0fe8f61e6c01f766a9d25ca3e953691464.
  ATTACHMENT ID: 12841649

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+0 tests included{color}.  The patch appears to be a documentation, build,
                        or dev patch that doesn't require tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 44 warning messages.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +parser.add_argument('url', nargs='?', help='The URL to the Phoenix Query Server.', default='http://localhost:8765')
+parser.add_argument('-u', '--user', help='Username for database authentication (unsupported).', default='none')
+parser.add_argument('-p', '--password', help='Password for database authentication (unsupported).', default='none')
+parser.add_argument('-a', '--authentication', help='Mechanism for HTTP authentication.', choices=('SPNEGO', 'BASIC', 'DIGEST', 'NONE'), default='')
+parser.add_argument('-s', '--serialization', help='Serialization type for HTTP API.', choices=('PROTOBUF', 'JSON'), default=None)

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/695//testReport/
Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/695//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/695//console

This message is automatically generated.

> Use argparse in sqlline-thin.py
> -------------------------------
>
>                 Key: PHOENIX-3517
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3517
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>             Fix For: 4.10.0
>
>         Attachments: PHOENIX-3517.patch
>
>
> sqlline-thin.py just does hand-rolled argument parsing. We can simplify the code, make better usage and validation choices, and support some extra options that we presently default to.
> Python's argparse does all of these for us.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)