phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Liew (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (PHOENIX-3531) Apply integration tests to the queryserver
Date Tue, 13 Dec 2016 21:12:58 GMT

     [ https://issues.apache.org/jira/browse/PHOENIX-3531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Kevin Liew updated PHOENIX-3531:
--------------------------------
    Description: 
We can add queryserver tests that extend the direct tests.
ie. QueryServerLikeExpressionIT extends LikeExpressionIT.

`getUrl` needs to be overridden to access the test cluster through the queryserver. We can't
override static methods or fields (but getUrl needs to be static because in many cases it
is used in @BeforeClass) but we could use dependency injection to inject a url-holder. This
way, the QueryServer~IT tests will be shell classes that simply override initialization of
the url-holder.

This could effectively double the amount of time taken to run integration tests.

Any objections to using dependency injection - or alternative solutions? Should we replicate
tests across the board or selectively?

  was:
We can add queryserver tests that extend the direct tests.
ie. QueryServerLikeExpressionIT extends LikeExpressionIT.

`getUrl` needs to be overridden to access the test cluster through the queryserver. We can't
override static methods or fields but we could use dependency injection to inject a url-holder.
This way, the QueryServer~IT tests will be shell classes that simply override initialization
of the url-holder.

This could effectively double the amount of time taken to run integration tests.

Any objections to using dependency injection - or alternative solutions? Should we replicate
tests across the board or selectively?


> Apply integration tests to the queryserver
> ------------------------------------------
>
>                 Key: PHOENIX-3531
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3531
>             Project: Phoenix
>          Issue Type: Task
>    Affects Versions: 4.8.0
>            Reporter: Kevin Liew
>            Priority: Minor
>              Labels: integration-tests, test-framework
>
> We can add queryserver tests that extend the direct tests.
> ie. QueryServerLikeExpressionIT extends LikeExpressionIT.
> `getUrl` needs to be overridden to access the test cluster through the queryserver. We
can't override static methods or fields (but getUrl needs to be static because in many cases
it is used in @BeforeClass) but we could use dependency injection to inject a url-holder.
This way, the QueryServer~IT tests will be shell classes that simply override initialization
of the url-holder.
> This could effectively double the amount of time taken to run integration tests.
> Any objections to using dependency injection - or alternative solutions? Should we replicate
tests across the board or selectively?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message