phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Dimiduk (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3517) Use argparse in sqlline-thin.py
Date Wed, 14 Dec 2016 00:22:58 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15746719#comment-15746719
] 

Nick Dimiduk commented on PHOENIX-3517:
---------------------------------------

bq. Would somethign like virtualenv be a tool to use here? Or should we just avoid opening
the can of worms on non-default-modules entirely?

Virtualenv would be super complicated for us; it's not worth it just for arg-parsing. If you're
happy with the library you're using, then just use it. If we really wanted docopt, i think
it has no dependencies, which means we could drop the file into our bin dir and just use it
(license permitting distribution, of course).

> Use argparse in sqlline-thin.py
> -------------------------------
>
>                 Key: PHOENIX-3517
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3517
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>             Fix For: 4.10.0
>
>         Attachments: PHOENIX-3517.patch
>
>
> sqlline-thin.py just does hand-rolled argument parsing. We can simplify the code, make
better usage and validation choices, and support some extra options that we presently default
to.
> Python's argparse does all of these for us.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message