phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas D'Silva (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3513) Throw SQLException instead of IllegalStateException when max commit size exceeded
Date Mon, 12 Dec 2016 23:10:58 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15743466#comment-15743466
] 

Thomas D'Silva commented on PHOENIX-3513:
-----------------------------------------

[~gjacoby]

Do you want to fix issue? its related to  PHOENIX-541.

Thanks,
Thomas 

> Throw SQLException instead of IllegalStateException when max commit size exceeded
> ---------------------------------------------------------------------------------
>
>                 Key: PHOENIX-3513
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3513
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Thomas D'Silva
>             Fix For: 4.10.0
>
>
> We should change this code in MutationState and implement the TODO here:
> {code}
>     private void throwIfTooBig() {
>         if (numRows > maxSize) {
>             // TODO: throw SQLException ?
>             throw new IllegalArgumentException("MutationState size of " + numRows + "
is bigger than max allowed size of " + maxSize);
>         }
>     }
> {code}
> Otherwise, it's difficult for clients to react to the exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message