phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maryannxue <...@git.apache.org>
Subject [GitHub] phoenix pull request #224: PHOENIX-3477 Support sequence arithmetic in Calci...
Date Tue, 06 Dec 2016 19:41:49 GMT
Github user maryannxue commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/224#discussion_r91152478
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/calcite/CalciteUtils.java ---
    @@ -1115,6 +1099,11 @@ public Void visitCall(RexCall call) {
                             || call.getKind() == SqlKind.NEXT_VALUE)) {
                     sequenceValueCall = call;
                 }
    +            if (sequenceValueCall == null){
    --- End diff --
    
    Think we are good to remove this class, right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message