phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lomoree <...@git.apache.org>
Subject [GitHub] phoenix pull request #223: PHOENIX-3488 Support COUNT(DISTINCT x) in Phoenix...
Date Thu, 01 Dec 2016 23:56:57 GMT
Github user lomoree commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/223#discussion_r90563623
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/calcite/rules/PhoenixConverterRules.java
---
    @@ -899,9 +899,6 @@ public static boolean isConvertible(Aggregate input) {
             if (input.getGroupSets().size() > 1)
                 return false;
             
    -        if (input.containsDistinctCall())
    --- End diff --
    
    @maryannxue added a commit to detect for any distinct calls that aren't of type COUNT.
Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message