Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 98AAA200BC5 for ; Mon, 7 Nov 2016 22:42:01 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 9778C160B10; Mon, 7 Nov 2016 21:42:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 11AFA160AE0 for ; Mon, 7 Nov 2016 22:42:00 +0100 (CET) Received: (qmail 84371 invoked by uid 500); 7 Nov 2016 21:41:59 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 83964 invoked by uid 99); 7 Nov 2016 21:41:59 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Nov 2016 21:41:59 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 6563C2C1F56 for ; Mon, 7 Nov 2016 21:41:59 +0000 (UTC) Date: Mon, 7 Nov 2016 21:41:59 +0000 (UTC) From: "Maryann Xue (JIRA)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-3355) Register Phoenix built-in functions as Calcite functions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 07 Nov 2016 21:42:01 -0000 [ https://issues.apache.org/jira/browse/PHOENIX-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645556#comment-15645556 ] Maryann Xue commented on PHOENIX-3355: -------------------------------------- Yes, think the default value approach is fine for all scalar functions, and those functions that need ExpressionManager for instantiation are aggregate functions. I suppose you have a function name to function info map for function resolving. If that's the case, things should be fine even without factories. I did notice that for CEIL, you'd switch to different concrete function class, like CeilDecimalExpression or CeilDateExpression, so you need to return all these signatures for CEIL and Calcite will do the parameter matching. Anyway, feel free to choose the factory approach if you think it'll work better. > Register Phoenix built-in functions as Calcite functions > -------------------------------------------------------- > > Key: PHOENIX-3355 > URL: https://issues.apache.org/jira/browse/PHOENIX-3355 > Project: Phoenix > Issue Type: Bug > Reporter: James Taylor > Assignee: Eric Lomore > Labels: calcite > Attachments: PHOENIX-3355.function_constructor.patch, PHOENIX-3355.wip, PHOENIX-3355.wip2 > > > We should register all Phoenix built-in functions that don't exist in Calcite. -- This message was sent by Atlassian JIRA (v6.3.4#6332)