Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@phoenix.apache.org
Date: Fri, 4 Nov 2016 05:36:58 +0000 (UTC)
From: "James Taylor (JIRA)" <jira@apache.org>
To: dev@phoenix.apache.org
Message-ID: <JIRA.13010221.1475775878000.184812.1478237818329@Atlassian.JIRA>
In-Reply-To: <JIRA.13010221.1475775878000@Atlassian.JIRA>
References: <JIRA.13010221.1475775878000@Atlassian.JIRA> <JIRA.13010221.1475775878739@arcas>
Subject: [jira] [Commented] (PHOENIX-3355) Register Phoenix built-in
 functions as Calcite functions
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 04 Nov 2016 05:37:00 -0000


    [ https://issues.apache.org/jira/browse/PHOENIX-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15635328#comment-15635328 ] 

James Taylor commented on PHOENIX-3355:
---------------------------------------

Patch looks good, [~maryannxue], but can you get rid of the nodeClass annotation everywhere as your new mechanism replaces that:
{code}
 @BuiltInFunction(name=ToTimestampFunction.NAME, nodeClass=ToTimestampParseNode.class,
{code}
Also, by getting rid of that annotation, you'll see all the places where you need to update to the new mechanism.

> Register Phoenix built-in functions as Calcite functions
> --------------------------------------------------------
>
>                 Key: PHOENIX-3355
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3355
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Eric Lomore
>              Labels: calcite
>         Attachments: PHOENIX-3355.function_constructor.patch, PHOENIX-3355.wip, PHOENIX-3355.wip2
>
>
> We should register all Phoenix built-in functions that don't exist in Calcite.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)