phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (PHOENIX-3479) Modulo support for non integer-types
Date Mon, 28 Nov 2016 23:42:58 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15703577#comment-15703577
] 

James Taylor edited comment on PHOENIX-3479 at 11/28/16 11:42 PM:
------------------------------------------------------------------

[~kliew] - thanks for the patch. Do you have a particular user/use case that would need this?
I've never seen someone ask for this. Most databases (Postgres, SQL Server,  don't support
modulo for doubles and floats (because it doesn't make much sense). I guess it'd be fine for
decimal.

Also, never add/remove enum values in the middle of the ExpressionType enum as it will wreak
havoc when an older/existing Phoenix client connects to a new Phoenix server since the expression
type is communicated through their ordinal value in the ExpressionType enum.


was (Author: jamestaylor):
[~kliew] - thanks for the patch. Do you have a particular user/use case that would need this?
I've never seen someone ask for this. Most databases (Postgres, SQL Server,  don't support
modulo for doubles and floats (because it doesn't make much sense). I guess it'd be fine for
decimal.

> Modulo support for non integer-types
> ------------------------------------
>
>                 Key: PHOENIX-3479
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3479
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.8.0
>            Reporter: Kevin Liew
>            Assignee: Kevin Liew
>            Priority: Minor
>         Attachments: PHOENIX-3479.2.patch, PHOENIX-3479.3.patch, PHOENIX-3479.patch
>
>
> MOD should be applicable to all numeric types



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message