phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (PHOENIX-3413) Ineffective null check in LiteralExpression#newConstant()
Date Wed, 02 Nov 2016 21:15:58 GMT

     [ https://issues.apache.org/jira/browse/PHOENIX-3413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ted Yu updated PHOENIX-3413:
----------------------------
    Description: 
{code}
        if (maxLength == null) {
            maxLength = type == null || !type.isFixedWidth() ? null : type.getMaxLength(value);
        }
{code}

The null check for type is ineffective - type is de-referenced in various places prior to
the above check.

  was:
{code}
        if (maxLength == null) {
            maxLength = type == null || !type.isFixedWidth() ? null : type.getMaxLength(value);
        }
{code}
The null check for type is ineffective - type is de-referenced in various places prior to
the above check.


> Ineffective null check in LiteralExpression#newConstant()
> ---------------------------------------------------------
>
>                 Key: PHOENIX-3413
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3413
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>
> {code}
>         if (maxLength == null) {
>             maxLength = type == null || !type.isFixedWidth() ? null : type.getMaxLength(value);
>         }
> {code}
> The null check for type is ineffective - type is de-referenced in various places prior
to the above check.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message