phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Lomore (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3355) Register Phoenix built-in functions as Calcite functions
Date Mon, 07 Nov 2016 21:55:58 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645589#comment-15645589
] 

Eric Lomore commented on PHOENIX-3355:
--------------------------------------

I actually think 1 is more intuitive, but what I'm possibly missing is how are we going to
alias without if statements (if(name==CEIL)) or an extra map that maps CEIL, etc. onto its
other function(s). To me, both of those solutions are bulky to maintain, and likely to break
in the future. If we do all instantiations in a Factory, there's a single standard way to
instantiate builtin functions. What do you think, is there another way to do aliasing in case
1?

> Register Phoenix built-in functions as Calcite functions
> --------------------------------------------------------
>
>                 Key: PHOENIX-3355
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3355
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Eric Lomore
>              Labels: calcite
>         Attachments: PHOENIX-3355.function_constructor.patch, PHOENIX-3355.wip, PHOENIX-3355.wip2
>
>
> We should register all Phoenix built-in functions that don't exist in Calcite.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message