phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Lomore (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3355) Register Phoenix built-in functions as Calcite functions
Date Mon, 07 Nov 2016 21:20:58 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645497#comment-15645497
] 

Eric Lomore commented on PHOENIX-3355:
--------------------------------------

[~maryannxue], the only other functions without the matching constructor are ToNumberFunction,
and ToCharFunction. They also work with the patch you provided.

Between 1 and 2, factories would handle the abstract class aliasing issues on the Phoenix
side which is a plus - FLOOR, NOW, ROUND, TRUNC, CEIL, REGEXP_REPLACE, REGEXP_SUBSTR, REGEXP_SPLIT
to be specific. If we opt to do 1, then as far as I can tell we would need additional static
handling of these aliasing use cases.

> Register Phoenix built-in functions as Calcite functions
> --------------------------------------------------------
>
>                 Key: PHOENIX-3355
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3355
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Eric Lomore
>              Labels: calcite
>         Attachments: PHOENIX-3355.function_constructor.patch, PHOENIX-3355.wip, PHOENIX-3355.wip2
>
>
> We should register all Phoenix built-in functions that don't exist in Calcite.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message