phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "chenglei (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (PHOENIX-3208) MutationState.toMutations method would throw a exception if multiple tables are upserted
Date Wed, 02 Nov 2016 11:16:58 GMT

     [ https://issues.apache.org/jira/browse/PHOENIX-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

chenglei updated PHOENIX-3208:
------------------------------
    Attachment:     (was: PHOENIX-3208_v2.patch)

> MutationState.toMutations method would throw a exception if multiple tables are upserted

> -----------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-3208
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3208
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.8.0
>            Reporter: chenglei
>
>         MutationState.toMutations method is to return the current uncommitted tables
mutations , but if multiple tables have been upserted , the toMutations method would throw
a exception:
>         {code:borderStyle=solid}
>      java.util.NoSuchElementException
> 	at com.google.common.collect.Iterators$1.next(Iterators.java:77)
> 	at org.apache.phoenix.execute.MutationState$1.next(MutationState.java:584)
> 	at org.apache.phoenix.execute.MutationState$1.next(MutationState.java:1)
> 	at org.apache.phoenix.execute.MutationState$2$1.next(MutationState.java:710)
> 	at org.apache.phoenix.execute.MutationState$2$1.next(MutationState.java:1)
> 	at org.apache.phoenix.execute.MutationState$2.next(MutationState.java:732)
> 	at org.apache.phoenix.execute.MutationState$2.next(MutationState.java:1)
> 	at org.apache.phoenix.util.PhoenixRuntime$1.next(PhoenixRuntime.java:354)
> 	at org.apache.phoenix.util.PhoenixRuntime$1.next(PhoenixRuntime.java:1)
>         {code}
>      
>         I write a simple unit test to reproduce this problem in my patch,the PhoenixRuntime.getUncommittedDataIterator
method internally uses the  MutationState.toMutations method:
> {code:borderStyle=solid} 
>     @Test
>     public void testToMutationsError() throws Exception {
>         Connection conn = null;
>         try {
>             conn=DriverManager.getConnection(getUrl());
>             conn.createStatement().execute(
>                     "create table MUTATION_TEST1"+
>                     "( id1 UNSIGNED_INT not null primary key,"+
>                       "appId1 VARCHAR)");
>             conn.createStatement().execute(
>                     "create table MUTATION_TEST2"+
>                     "( id2 UNSIGNED_INT not null primary key,"+
>                       "appId2 VARCHAR)");
>             conn.createStatement().execute("upsert into MUTATION_TEST1(id1,appId1) values(111,'app1')");
>             conn.createStatement().execute("upsert into MUTATION_TEST2(id2,appId2) values(222,'app2')");
>             Iterator<Pair<byte[],List<KeyValue>>> dataTableNameAndMutationKeyValuesIter
=
>                     PhoenixRuntime.getUncommittedDataIterator(conn);
>             assertTrue(dataTableNameAndMutationKeyValuesIter.hasNext());
>             Pair<byte[],List<KeyValue>> pair=dataTableNameAndMutationKeyValuesIter.next();
>             String tableName1=Bytes.toString(pair.getFirst());
>             List<KeyValue> keyValues1=pair.getSecond();
>             assertTrue(dataTableNameAndMutationKeyValuesIter.hasNext());
>             pair=dataTableNameAndMutationKeyValuesIter.next();
>             String tableName2=Bytes.toString(pair.getFirst());
>             List<KeyValue> keyValues2=pair.getSecond();
>             if("MUTATION_TEST1".equals(tableName1)) {
>                 assertTable(tableName1, keyValues1, tableName2, keyValues2);
>             }
>             else {
>                 assertTable(tableName2, keyValues2, tableName1, keyValues1);
>             }
>             assertTrue(!dataTableNameAndMutationKeyValuesIter.hasNext());
>         }
>         finally {
>             if(conn!=null) {
>                 conn.close();
>             }
>         }
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message