phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-2890) Extend IndexTool to allow incremental index rebuilds
Date Wed, 30 Nov 2016 08:40:58 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15707961#comment-15707961
] 

ASF GitHub Bot commented on PHOENIX-2890:
-----------------------------------------

Github user chrajeshbabu commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/210#discussion_r90188400
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
    @@ -305,16 +305,27 @@
                         TENANT_ID + "," +
                         TABLE_SCHEM + "," +
                         TABLE_NAME + "," +
    -                    INDEX_STATE +
    +                    INDEX_STATE + "," +
    +                    ASYNC_REBUILD_TIMESTAMP + " " + PLong.INSTANCE.getSqlTypeName() +
    +                    ") VALUES (?, ?, ?, ?, ?)";
    +    
    +    private static final String UPDATE_INDEX_REBUILD_ASYNC_STATE =
    +            "UPSERT INTO " + SYSTEM_CATALOG_SCHEMA + ".\"" + SYSTEM_CATALOG_TABLE + "\"(
" +
    +                    TENANT_ID + "," +
    +                    TABLE_SCHEM + "," +
    +                    TABLE_NAME + "," +
    +                    ASYNC_REBUILD_TIMESTAMP + " " + PLong.INSTANCE.getSqlTypeName() +
                         ") VALUES (?, ?, ?, ?)";
    +    
         private static final String UPDATE_INDEX_STATE_TO_ACTIVE =
                 "UPSERT INTO " + SYSTEM_CATALOG_SCHEMA + ".\"" + SYSTEM_CATALOG_TABLE + "\"(
" +
                         TENANT_ID + "," +
                         TABLE_SCHEM + "," +
                         TABLE_NAME + "," +
                         INDEX_STATE + "," +
    -                    INDEX_DISABLE_TIMESTAMP +
    -                    ") VALUES (?, ?, ?, ?, ?)";
    +                    INDEX_DISABLE_TIMESTAMP +","+
    +                    ASYNC_REBUILD_TIMESTAMP + " " + PLong.INSTANCE.getSqlTypeName() +
    --- End diff --
    
    Ok. It's fine. Thanks Ankit



> Extend IndexTool to allow incremental index rebuilds
> ----------------------------------------------------
>
>                 Key: PHOENIX-2890
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2890
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Ankit Singhal
>            Assignee: Ankit Singhal
>            Priority: Minor
>             Fix For: 4.10.0
>
>         Attachments: PHOENIX-2890.patch, PHOENIX-2890_wip.patch
>
>
> Currently , IndexTool is used for initial index rebuild but I think we should extend
it to be used for recovering index from last disabled timestamp too. 
> In general terms if we run IndexTool on already existing/new index, then it should follow
the same semantics as followed by background Index rebuilding thread.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message