phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jmahonin <...@git.apache.org>
Subject [GitHub] phoenix pull request #221: PHOENIX-3427 fix saveToRdd for tenant-specific co...
Date Thu, 10 Nov 2016 16:50:06 GMT
Github user jmahonin commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/221#discussion_r87435881
  
    --- Diff: phoenix-spark/src/main/scala/org/apache/phoenix/spark/ProductRDDFunctions.scala
---
    @@ -16,19 +16,20 @@ package org.apache.phoenix.spark
     import org.apache.hadoop.conf.Configuration
     import org.apache.hadoop.io.NullWritable
     import org.apache.phoenix.mapreduce.PhoenixOutputFormat
    -import org.apache.phoenix.mapreduce.util.{ColumnInfoToStringEncoderDecoder, PhoenixConfigurationUtil}
    +import org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil
     import org.apache.spark.Logging
     import org.apache.spark.rdd.RDD
    +
     import scala.collection.JavaConversions._
     
     class ProductRDDFunctions[A <: Product](data: RDD[A]) extends Logging with Serializable
{
     
       def saveToPhoenix(tableName: String, cols: Seq[String],
    -                    conf: Configuration = new Configuration, zkUrl: Option[String] =
None)
    +                    conf: Configuration = new Configuration, zkUrl: Option[String] =
None, tenantId: Option[String] = None)
    --- End diff --
    
    I'll try and take a look today. We might be shoe-horned into only passing settings through
the Configuration object vs Properties, but I'm not 100% sure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message