phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Samarth Jain (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3424) Backward compatibility failure: 4.8 -> 4.9 upgrade
Date Sun, 30 Oct 2016 07:29:58 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15619486#comment-15619486
] 

Samarth Jain commented on PHOENIX-3424:
---------------------------------------

Patch looks good, [~jamestaylor]. 

One nit to fix:
{code}
catch (InterruptedException e) {
+            Thread.currentThread().isInterrupted();
+            throw new SQLExceptionInfo.Builder(SQLExceptionCode.INTERRUPTED_EXCEPTION).setRootCause(e).build().buildException();
         }
{code}

to
 
{code}
catch (InterruptedException e) {
+            Thread.currentThread().interrupt();
+            throw new SQLExceptionInfo.Builder(SQLExceptionCode.INTERRUPTED_EXCEPTION).setRootCause(e).build().buildException();
         }
{code}


> Backward compatibility failure: 4.8 -> 4.9 upgrade
> --------------------------------------------------
>
>                 Key: PHOENIX-3424
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3424
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Mujtaba Chohan
>            Assignee: James Taylor
>             Fix For: 4.9.0
>
>         Attachments: PHOENIX-3424.patch, PHOENIX-3424_wip.patch
>
>
> {noformat}
> Caused by: java.lang.IllegalStateException: Didn't find all required key values in 'COLUMN_FAMILY'
column metadata row
> 	at org.apache.phoenix.coprocessor.MetaDataEndpointImpl.addColumnToTable(MetaDataEndpointImpl.java:671)
> 	at org.apache.phoenix.coprocessor.MetaDataEndpointImpl.getTable(MetaDataEndpointImpl.java:958)
> 	at org.apache.phoenix.coprocessor.MetaDataEndpointImpl.buildTable(MetaDataEndpointImpl.java:543)
> 	at org.apache.phoenix.coprocessor.MetaDataEndpointImpl.loadTable(MetaDataEndpointImpl.java:1210)
> 	at org.apache.phoenix.coprocessor.MetaDataEndpointImpl.createTable(MetaDataEndpointImpl.java:1389)
> 	... 10 more (state=08000,code=101)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message