phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Lomore (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3355) Register Phoenix built-in functions as Calcite functions
Date Mon, 10 Oct 2016 15:30:20 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15562592#comment-15562592
] 

Eric Lomore commented on PHOENIX-3355:
--------------------------------------

Question for [~maryannxue] and [~jamestaylor],
Currently, DDL statements leverage the phoenix runtime, and hence use phoenix registered builtin
functions. Is there ever a plan to fully move away from phoenix execution?
If we don't then it appears we need each function to be implemented in Calcite and Phoenix.
In the DDL case, using the phoenix runtime, and for all other queries, calcite runtime.
Therefore, are we looking to make each builtin function registered once but usable by both,
or, duplicate the functions have one implementation in Calcite, and another in Phoenix?

Making these functions dual compatible may be difficult to the vastly different structures
they implement.

Ex//
{{Phoenix : CurrentDateFunction.java}}
{{Calcite   : SqlCurrentDateFunction.java}} -- extends SqlFunction

> Register Phoenix built-in functions as Calcite functions
> --------------------------------------------------------
>
>                 Key: PHOENIX-3355
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3355
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Eric Lomore
>              Labels: calcite
>
> We should register all Phoenix built-in functions that don't exist in Calcite.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message