phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chrajeshbabu <...@git.apache.org>
Subject [GitHub] phoenix pull request #210: PHOENIX-2890 Extend IndexTool to allow incrementa...
Date Tue, 18 Oct 2016 07:26:03 GMT
Github user chrajeshbabu commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/210#discussion_r83795010
  
    --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexMetadataIT.java
---
    @@ -216,6 +219,15 @@ public void testIndexCreateDrop() throws Exception {
                 assertFalse(rs.next());
                 
                 assertActiveIndex(conn, INDEX_DATA_SCHEMA, indexDataTable);
    +            
    +            ddl = "ALTER INDEX " + indexName + " ON " + INDEX_DATA_SCHEMA + QueryConstants.NAME_SEPARATOR
+ indexDataTable + " REBUILD ASYNC";
    +            conn.createStatement().execute(ddl);
    +            // Verify the metadata for index is correct.
    +            rs = conn.getMetaData().getTables(null, StringUtil.escapeLike(INDEX_DATA_SCHEMA),
indexName , new String[] {PTableType.INDEX.toString()});
    +            assertTrue(rs.next());
    +            assertEquals(indexName , rs.getString(3));
    +            assertEquals(PIndexState.BUILDING.toString(), rs.getString("INDEX_STATE"));
    --- End diff --
    
    This is making active index to rebuild can we add an assertion what is time from which
we rebuild? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message