phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maryannxue <...@git.apache.org>
Subject [GitHub] phoenix pull request #213: PHOENIX-2827 Support OFFSET in Calcite-Phoenix
Date Fri, 30 Sep 2016 21:24:03 GMT
Github user maryannxue commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/213#discussion_r81419684
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/calcite/rules/PhoenixConverterRules.java
---
    @@ -232,8 +232,7 @@ public RelNode convert(RelNode rel) {
             private static Predicate<LogicalSort> HAS_FETCH = new Predicate<LogicalSort>()
{
                 @Override
                 public boolean apply(LogicalSort input) {
    -                return input.offset == null 
    -                        && input.fetch != null;
    +                return input.fetch != null;
    --- End diff --
    
    should be "input.fetch != null || input.offset != null"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message