phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maryannxue <...@git.apache.org>
Subject [GitHub] phoenix pull request #212: PHOENIX-3264 Allow TRUE and FALSE to be used as l...
Date Thu, 29 Sep 2016 18:25:31 GMT
Github user maryannxue commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/212#discussion_r81200946
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/calcite/CalciteUtils.java ---
    @@ -1036,4 +1048,40 @@ public Void visitCall(RexCall call) {
                 return null;
             }
         }
    +
    +    public static Object convertLiteral(SqlLiteral literal, PhoenixRelImplementor implementor)
{
    --- End diff --
    
    Other convertXXX methods are to convert RexNode to Expression, so I'm thinking something
like "convertSqlLiteral(...)" could be less confusing?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message