phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kliewkliew <...@git.apache.org>
Subject [GitHub] phoenix pull request #208: PHOENIX-3046 `NOT LIKE '%'` unexpectedly returns ...
Date Sat, 10 Sep 2016 02:59:22 GMT
Github user kliewkliew commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/208#discussion_r78270028
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/ExpressionCompiler.java
---
    @@ -523,7 +523,12 @@ public Expression visitLeave(LikeParseNode node, List<Expression>
children) thro
                     byte[] wildcard = {StringUtil.MULTI_CHAR_LIKE};
                     StringUtil.fill(nullExpressionString, 0, pattern.length(), wildcard,
0, 1, false);
                     if (pattern.equals(new String (nullExpressionString))) {
    -                    return IsNullExpression.create(lhs, true, context.getTempPtr());
    +                    if (node.isNegate()) {
    +                        return LiteralExpression.newConstant(false, Determinism.ALWAYS);
    --- End diff --
    
    Though it is probably more useful to compile to `WHERE col IS NULL`; I don't see a use
case for ` select * from table where false`. I'll change it to compile to `WHERE col IS NULL`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message