phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kliewkliew <...@git.apache.org>
Subject [GitHub] phoenix pull request #200: PHOENIX-2641 Implicit wildcard in LIKE predicate ...
Date Fri, 02 Sep 2016 16:24:36 GMT
Github user kliewkliew commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/200#discussion_r77374014
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/ExpressionCompiler.java
---
    @@ -517,8 +518,13 @@ public Expression visitLeave(LikeParseNode node, List<Expression>
children) thro
                           return new ComparisonExpression(Arrays.asList(lhs,rhs), op);
                       }
                     }
    -            } else if (index == 0 && pattern.length() == 1) {
    -                return IsNullExpression.create(lhs, true, context.getTempPtr());
    +            } else {
    +                byte[] nullExpressionString = new byte[pattern.length()];
    +                byte[] wildcard = {StringUtil.MULTI_CHAR_LIKE};
    +                StringUtil.fill(nullExpressionString, 0, pattern.length(), wildcard,
0, 1, false);
    +                if (pattern.equals(new String (nullExpressionString))) {
    --- End diff --
    
    I guess that it is unlikely enough that a user would submit a query with `~ LIKE '%%'`
instead of `~ LIKE '%'` that it isn't worth the overhead of covering that case. 
    
    I did that in revision 53242fdb31c23879a9ae13ef6f429d585c35b307 with `pattern.equals(Character.toString(StringUtil.MULTI_CHAR_LIKE))`
and tested it. That revision works if you would like to commit that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message