Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 92C31200B65 for ; Wed, 3 Aug 2016 04:45:27 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 915F1160AA8; Wed, 3 Aug 2016 02:45:27 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D79A3160A76 for ; Wed, 3 Aug 2016 04:45:26 +0200 (CEST) Received: (qmail 12736 invoked by uid 500); 3 Aug 2016 02:45:20 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 12708 invoked by uid 99); 3 Aug 2016 02:45:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Aug 2016 02:45:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 98BE52C0D5E for ; Wed, 3 Aug 2016 02:45:20 +0000 (UTC) Date: Wed, 3 Aug 2016 02:45:20 +0000 (UTC) From: "Hudson (JIRA)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-3128) Remove extraneous operations during upsert with local immutable index MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 03 Aug 2016 02:45:27 -0000 [ https://issues.apache.org/jira/browse/PHOENIX-3128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405211#comment-15405211 ] Hudson commented on PHOENIX-3128: --------------------------------- SUCCESS: Integrated in Phoenix-master #1351 (See [https://builds.apache.org/job/Phoenix-master/1351/]) PHOENIX-3128 Remove extraneous operations during upsert with local (jamestaylor: rev ca7c36d59247795d92f7fc23a4ae4038da215284) * phoenix-core/src/main/java/org/apache/phoenix/index/PhoenixIndexMetaData.java * phoenix-core/src/main/java/org/apache/phoenix/compile/PostLocalIndexDDLCompiler.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexIT.java * phoenix-core/src/main/java/org/apache/phoenix/hbase/index/covered/IndexMetaData.java * phoenix-core/src/main/java/org/apache/phoenix/util/TransactionUtil.java * phoenix-core/src/main/java/org/apache/phoenix/index/PhoenixTransactionalIndexer.java * phoenix-core/src/main/java/org/apache/phoenix/hbase/index/covered/NonTxIndexBuilder.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/DistinctPrefixFilterIT.java * phoenix-core/src/main/java/org/apache/phoenix/schema/PTableImpl.java * phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java > Remove extraneous operations during upsert with local immutable index > --------------------------------------------------------------------- > > Key: PHOENIX-3128 > URL: https://issues.apache.org/jira/browse/PHOENIX-3128 > Project: Phoenix > Issue Type: Bug > Reporter: Junegunn Choi > Assignee: Junegunn Choi > Fix For: 4.8.0 > > Attachments: PHOENIX-3128.patch, PHOENIX-3128_v2.patch, PHOENIX-3128_v3.patch, PHOENIX-3128_v4.patch, PHOENIX-3128_v5.patch, PHOENIX-3128_v6.patch, PHOENIX-3128_v7.patch, PHOENIX-3128_v8.patch, PHOENIX-3128_wip.patch > > > Upsert to a table with a local immutable index is supposed to be more efficient than to a table with a local mutable index, but it's actually slower (in our environment by 30%) due to extraneous operations involved. > The problem is twofold: > 1. Client unnecessarily prepares and sends index update. > 2. Index cleanup is done regardless of the immutability of the table. -- This message was sent by Atlassian JIRA (v6.3.4#6332)